On Mon, 2017-04-10 at 12:15 +0200, Juan A. Suarez Romero wrote: > On Fri, 2017-04-07 at 19:38 +0100, Emil Velikov wrote: > > On 7 April 2017 at 12:30, Juan A. Suarez Romero <jasua...@igalia.com> wrote: > > > Both scripts does not use a file with the commits to ignore. So if we > > > have handled one of the suggested commits and decided we won't pick it, > > > the scripts will continue suggesting them. > > > > > > This commits adds support for a bin/.cherry-ignore-extra where we can > > > put the commits not explicitly rejected (those would be in the > > > bin/.cherry-ignore) but we want the scripts don't suggest them because > > > we know those won't be picked for stable. > > > > > > > Don't see much value in having the extra file. The patch is not > > suitable, regardless of how it was flagged. > > > > Ok. I'll send a patch to use .cherry-ignore for all the cases.
* .cherry-ignore holds the rejections from actual nominations done by developers. * .cherry-ignore-extra holds the rejections from "false positives" raised by the existing scripts. I actually find useful to have both files so it is easy to know that, while not being an overcomplicated solution. What do you think, Emil, can we go with the previous v2 solution and discard the v3? -- Br, Andres _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
