On Wednesday, April 19, 2017 4:56:13 PM PDT Rafael Antognolli wrote: > From: Kenneth Graunke <kenn...@whitecape.org> > > Both GS and SOL have these fields. Some were ReorderEnable = true, > some were ReorderMode = REORDER_TRAILING, and some were just TRAILING. > > Signed-off-by: Kenneth Graunke <kenn...@whitecape.org> > --- > src/intel/genxml/gen6.xml | 5 ++++- > src/intel/genxml/gen7.xml | 5 ++++- > src/intel/vulkan/genX_pipeline.c | 4 ---- > 3 files changed, 8 insertions(+), 6 deletions(-)
I'm a little conflicted about this...I had forgotten that the Gen6-7 GS doesn't actually do proper "trailing" reordering. It just...reorders them...differently. So "Reorder Enable" feels kind of appropriate. That said, it feels stupid to have ifdefs to set the same exact bit, and we call it REORDER_TRAILING in the existing gen7_gs_state.c code. We just have a comment pointing out that it's kinda broken. So, I suppose it's fine. I can't really give an R-b for my own patch though :)
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
