On 3 May 2017 at 15:18, Daniel Stone <dan...@fooishbar.org> wrote: > On 3 May 2017 at 15:15, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> On 2 May 2017 at 19:49, Daniel Stone <dani...@collabora.com> wrote: >>> - ret |= mod; >>> + ret |= (uint64_t)(mod & 0xffffffff); >>> >> I was itching to suggest the following from the start, but your patch >> also works ;-) >> Fixes: 8378c576abd ("gbm: Export a get modifiers") >> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> >> >> return (uint64_t)mod_hi << 32 | (uint64_t)mod_lo & 0xffffffff; > > Thanks Emil! I already pushed with Ben's R-b last night, as it was a > fairly critical fix for anyone using the new ABI. I'll try to be more > careful about using the 'Fixes' tags in future. :( > No problems, Dan. Forwarding to mesa-stable@ - so we don't miss it where it matters.
-Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev