On Wednesday, May 3, 2017 10:47:57 AM PDT Pohjolainen, Topi wrote:
> On Mon, May 01, 2017 at 06:43:04PM -0700, Rafael Antognolli wrote:
> > +void
> > +genX(init_atoms)(struct brw_context *brw)
> > +{
> > +#if GEN_GEN < 6
> > + static const struct brw_tracked_state *render_atoms[] =
> > + {
>
> Given that the assert and the dispatch of copy in the end is common code and
> expects all the if-else blocks to agree on the name "render_atoms", we could
> have that outside the if-else ladder as well. Just a thought, either way:
>
> Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com>I was actually thinking we might want to combine the gen7/8 atoms lists, with #if GEN_GEN around the few that are different...might reduce some duplication. Haven't tried it to see how it would look yet.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
