Hi Varad, On 23 May 2017 at 14:19, Varad Gautam <varad.gau...@collabora.com> wrote: > On Mon, 2017-05-22 at 14:03 +0100, Emil Velikov wrote: >> On 19 May 2017 at 10:37, Daniel Stone <dani...@collabora.com> wrote: >> > + if (external_only != NULL) { >> > + for (i = 0; i < *count && i < max; i++) >> > + external_only[i] = EGL_TRUE; >> >> If I'm correctly understanding the spec, each bool represents if the >> respective format/modifier combo. >> Do we want to unconditionally enable all here? > > Yes, bool external_only[i] corresponds to <format, modifier[i]> combination. > > I am uncertain on what using modifiers with non-external images would mean, > since modifiers are only specific to the dmabufs path, which bind as external > textures. > > Would we ever have modifiers with non-GL_TEXTURE_EXTERNAL_OES images? (should > external_only be false perhaps for MOD_INVALID?)
We definitely will. YUV images will probably going to require binding as TEXTURE_EXTERNAL, but if you're importing an RGB image (which may even be pre-tiled), that can almost certainly just be bound to TEXTURE_2D. So maybe the pipe callbacks need to gain an external_only query flag. Sorry I missed this whilst picking up the series. Cheers, Daniel _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev