Android does not support pixmaps, so this should be set to false there. I think otherwise this should be fine.

On 06/05/2017 02:52 AM, Emil Velikov wrote:
From: Emil Velikov <emil.veli...@collabora.com>

There's nothing platform specific in the extension - all the required
core parts are already implemented.

Signed-off-by: Emil Velikov <emil.veli...@collabora.com>
---
This and the following are an RFC, since I'm not 100% sure if there
isn't anything too subtle that enforces the current state of affairs.

E.g. EGL_NOK_swap_region - the extension documentation is nowhere to be
found, there's no implementations or software out there (that I can see)
which honours it, yet we implement it. Barring the single piglit test.

  src/egl/drivers/dri2/egl_dri2.c     | 1 +
  src/egl/drivers/dri2/platform_x11.c | 2 --
  2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
index d31a0bf8e09..f6d2d5464a8 100644
--- a/src/egl/drivers/dri2/egl_dri2.c
+++ b/src/egl/drivers/dri2/egl_dri2.c
@@ -666,6 +666,7 @@ dri2_setup_screen(_EGLDisplay *disp)
     assert(dri2_dpy->image_driver || dri2_dpy->dri2 || dri2_dpy->swrast);
     disp->Extensions.KHR_no_config_context = EGL_TRUE;
     disp->Extensions.KHR_surfaceless_context = EGL_TRUE;
+   disp->Extensions.NOK_texture_from_pixmap = EGL_TRUE;
if (dri2_renderer_query_integer(dri2_dpy,
                                     __DRI2_RENDERER_HAS_FRAMEBUFFER_SRGB))
diff --git a/src/egl/drivers/dri2/platform_x11.c 
b/src/egl/drivers/dri2/platform_x11.c
index 8d8c7cb4905..1985818e119 100644
--- a/src/egl/drivers/dri2/platform_x11.c
+++ b/src/egl/drivers/dri2/platform_x11.c
@@ -1359,7 +1359,6 @@ dri2_initialize_x11_dri3(_EGLDriver *drv, _EGLDisplay 
*disp)
if (!dri2_dpy->is_different_gpu)
        disp->Extensions.KHR_image_pixmap = EGL_TRUE;
-   disp->Extensions.NOK_texture_from_pixmap = EGL_TRUE;
     disp->Extensions.CHROMIUM_sync_control = EGL_TRUE;
     disp->Extensions.EXT_buffer_age = EGL_TRUE;
@@ -1459,7 +1458,6 @@ dri2_initialize_x11_dri2(_EGLDriver *drv, _EGLDisplay *disp) disp->Extensions.KHR_image_pixmap = EGL_TRUE;
     disp->Extensions.NOK_swap_region = EGL_TRUE;
-   disp->Extensions.NOK_texture_from_pixmap = EGL_TRUE;
     disp->Extensions.NV_post_sub_buffer = EGL_TRUE;
     disp->Extensions.CHROMIUM_sync_control = EGL_TRUE;
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to