On Tue, Jun 6, 2017 at 5:17 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote:
> Hi Alex, > > On 6 June 2017 at 10:42, Alex Smith <asm...@feralinteractive.com> wrote: > > This means it can be reused for other Vulkan drivers. Also fix up a > > typo, need to search for '.' in the version string rather than ','. > > > > Signed-off-by: Alex Smith <asm...@feralinteractive.com> > > --- > > > +uint32_t vk_get_driver_version(void) > > +{ > ... > > + uint32_t version = VK_MAKE_VERSION(major, minor, patch); > > + return version; > Nit: return directly? > > Either way, the series is (thanks for the Android squash and dropping > the util/ bit) > Agreed. > Reviewed-by: Emil Velikov <emil.veli...@collabora.com> > > If anyone wants to pursue the devel vs rc topic, below is an idea how. > Some devs thought it was confusing a while back, so be warned. > > 17.0.0 dev -> 16.90.0 > 18.0.0 dev -> 17.90.0 > > 17.0.0 rc1 -> 16.91.0 > 18.0.0 rc2 -> 17.92.0 > > 17.1.0 dev -> 17.0.90 > 18.2.0 dev -> 17.1.90 > > 17.1.0 rc1 -> 17.0.91 > 18.2.0 rc2 -> 18.1.92 > That shouldn't be too hard to implement but someone who's feeling pedantic can do that as part of a later patch. --Jason
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev