On 12/14/2011 11:16 PM, Chia-I Wu wrote:
On Thu, Dec 15, 2011 at 5:21 AM, Ian Romanick<i...@freedesktop.org>  wrote:
On 12/14/2011 12:24 PM, Fredrik Höglund wrote:

diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index 3cb1a5b..ff15476 100644
--- a/src/egl/main/eglapi.c
+++ b/src/egl/main/eglapi.c
@@ -951,6 +951,9 @@ eglGetProcAddress(const char *procname)
  #ifdef EGL_ANDROID_swap_rectangle
        { "eglSetSwapRectangleANDROID", (_EGLProc)
eglSetSwapRectangleANDROID },
  #endif
+#ifdef EGL_NV_post_sub_buffer


It seems weird that we define this in our own header file, then check to see
if it's defined.  I understand that the new code is just following the
pattern of the existing code.  Perhaps Kristian or Chia-I can shed some
light on this convention.
The convention was established before I started working on EGL.  I
agree with you that those checks are unnecessary (and ugly..).  I will
remove them in a separate patch, if no one objects.

I would support that.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to