On Wed, Jun 14, 2017 at 11:23 PM, Timothy Arceri <tarc...@itsqueeze.com> wrote: > > > On 15/06/17 04:10, Marek Olšák wrote: >> >> On Wed, Jun 14, 2017 at 7:27 PM, Marek Olšák <mar...@gmail.com> wrote: >>> >>> On Tue, Jun 13, 2017 at 8:10 AM, Timothy Arceri <tarc...@itsqueeze.com> >>> wrote: >>>> >>>> >>>> >>>> On 13/06/17 04:18, Marek Olšák wrote: >>>>> >>>>> >>>>> From: Marek Olšák <marek.ol...@amd.com> >>>>> >>>>> AMD SI-VI use this. GFX9 doesn't. We can stop doing this for SI-VI >>>>> since >>>>> border color swizzling is broken there anyway. The only other user of >>>>> this >>>>> code is nouveau. >>>> >>>> >>>> >>>> Maybe move this comment into the code as a TODO? I was a little confused >>>> at >>>> first as I thought this commit was meant to make the change. With that: >>> >>> >>> I don't understand. What are you confused about? >> >> >> The commit message talks about radeonsi, but this patch is for >> st/mesa. st/mesa doesn't care which drivers use the codepath. > > > Well how do you intent to stop using this? Why is the commit message for a > st change talking about radeonsi? I was assuming you wanted to eventually > remove this code path from all drivers (or at least skip it for some) in > which case making this a code comment would make sense, otherwise why do you > even talk about this in the commit message?
You're right. I'll just remove that commit message. Marek _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
