On Fri, Jun 16, 2017 at 8:24 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi Rob, > > There's a handful of small nitpicks, but nothing serious. > > On 15 June 2017 at 21:47, Robert Foss <robert.f...@collabora.com> wrote: >> From: Rob Herring <r...@kernel.org> >> >> Add etnaviv to Android makefiles. >> >> Signed-off-by: Rob Herring <r...@kernel.org> >> ---
>> @@ -46,7 +47,7 @@ LOCAL_CPPFLAGS += -std=c++11 >> >> # We need libmesa_nir to get NIR's generated include directories. >> LOCAL_MODULE := libmesa_gallium >> -LOCAL_STATIC_LIBRARIES += libmesa_nir >> +LOCAL_STATIC_LIBRARIES += libmesa_nir libmesa_loader >> > Do we really need the loader here? Afaict module does not export any > headers/etc that we need? > We should only need it in the final link stage, although it's there already. I could be left over from the first iteration of renderonly. These patches started a while back. Rob _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
