2011/12/23 Mathias Fröhlich <mathias.froehl...@gmx.net>: > > Hi, > > On Thursday, December 22, 2011 18:30:44 Brian Paul wrote: >> I'm not sure if "playback_vertex_list" is more like DRAW_BEGIN_END or >> DRAW_ARRAYS. >> Maybe add a DRAW_DISPLAY_LIST enum value? > > It's more like begin/end I think. > The begin/end code just sets the array state below the state tracking of the > api function. And the way this happens is very much the same for save and draw > when you look at the code that binds the vbos. > > To me it makes perfectly sense that the vbo_{save,exec}_draw just disturbs the > vbo_array_draw path. So, probably a simple flag that marks if we were drawing > by vbo_{save,exec}_draw.c the last time would do the job also. > > But if you think you want to distinguish this, go ahead... > I also believe that this difference we are talking about will only trigger in > very few untypical cases. > > Greetings > > Mathias
I think I'll go with the DRAW_DISPLAY_LIST option just to be safe. The failure path/case is pretty bad when it happens. And like you said, it's probably a rare use case. I'll post a new patch in a bit. -Brian _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev