Hi, On 19 July 2017 at 10:05, Christian Gmeiner <christian.gmei...@gmail.com> wrote: > 2017-07-04 17:46 GMT+02:00 Lucas Stach <l.st...@pengutronix.de>: >> diff --git a/src/gallium/drivers/etnaviv/etnaviv_texture.c >> b/src/gallium/drivers/etnaviv/etnaviv_texture.c >> index 954daea7ba57..bc3655488ba5 100644 >> --- a/src/gallium/drivers/etnaviv/etnaviv_texture.c >> +++ b/src/gallium/drivers/etnaviv/etnaviv_texture.c >> @@ -187,7 +187,7 @@ etna_create_sampler_view(struct pipe_context *pctx, >> struct pipe_resource *prsc, >> templat.bind &= ~(PIPE_BIND_DEPTH_STENCIL | >> PIPE_BIND_RENDER_TARGET | >> PIPE_BIND_BLENDABLE); >> res->texture = >> - etna_resource_alloc(pctx->screen, ETNA_LAYOUT_TILED, &templat); >> + etna_resource_alloc(pctx->screen, ETNA_LAYOUT_TILED, 0, >> &templat); >> } >> >> if (!res->texture) { >> diff --git a/src/gallium/drivers/etnaviv/etnaviv_transfer.c >> b/src/gallium/drivers/etnaviv/etnaviv_transfer.c >> index 27e1be19579a..3795c7839081 100644 >> --- a/src/gallium/drivers/etnaviv/etnaviv_transfer.c >> +++ b/src/gallium/drivers/etnaviv/etnaviv_transfer.c >> @@ -203,7 +203,7 @@ etna_transfer_map(struct pipe_context *pctx, struct >> pipe_resource *prsc, >> templ.nr_samples = 0; >> templ.bind = PIPE_BIND_RENDER_TARGET; >> >> - trans->rsc = etna_resource_alloc(pctx->screen, ETNA_LAYOUT_LINEAR, >> &templ); >> + trans->rsc = etna_resource_alloc(pctx->screen, ETNA_LAYOUT_LINEAR, 0, >> &templ); >> if (!trans->rsc) { >> slab_free(&ctx->transfer_pool, trans); >> return NULL;
Using DRM_FORMAT_MOD_LINEAR would be more clear than 0 here. Short of that, patch 6 is: Acked-by: Daniel Stone <dani...@collabora.com> and patches 7-10 are: Reviewed-by: Daniel Stone <dani...@collabora.com> Thanks for doing this! Unfortunately I haven't been able to get to testing on a Wandboard yet; oh well. Looks fine anyway. Cheers, Daniel _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev