On Wed,  4 Jan 2012 04:07:24 -0800, Kenneth Graunke <kenn...@whitecape.org> 
wrote:
> textureSize() returns an int, ivec2, or ivec3, but never an ivec4.
> Creating the destination register as an ivec4 triggered later failures,
> even though the register did hold the proper values.
> 
> For example, piglit test vs-textureSize-compare calls textureSize on a
> 2D texture and compares the result to an expected value.  Unfortunately,
> our generated code also tried to compare the third and fourth components
> which were undefined, and failed.
> 
> Fixes piglit test vs-textureSize-compare as well as 19 subcases of
> oglconform's glsl-bif-tex-size test.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44339
> Signed-off-by: Kenneth Graunke <kenn...@whitecape.org>

Makes sense to me.

Reviewed-by: Eric Anholt <e...@anholt.net>

Attachment: pgpUsCpzxDmtj.pgp
Description: PGP signature

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to