On Thursday, 2017-08-24 11:07:27 +0100, Emil Velikov wrote: > On 23 August 2017 at 18:25, Rob Herring <r...@kernel.org> wrote: > > The build against AOSP master and O is broken: > > > > external/mesa3d/include/EGL/eglplatform.h:100:10: fatal error: > > 'android/native_window.h' file not found > > > > native_window.h has moved and is now part of libnativewindow library, so > > add this dependency. > > > That ones seems resolved upstream [1] in a rather nice way IMHO. > Note that we cannot use the upstream header since there's local changes in > Mesa. > > I've attempted to address the underlying issue by moving from implicit > to explicit, Vulkan-like, platform detection/selection here [2]. I'll > see about getting that sorted with Khronos, but using a patch similar > to [1] might be the better option? > > What do you guys think?
I agree, it's cleaner to align with Khronos and simply forward declare the struct, rather than having to track changes in include paths and libraries. Sending this patch in a minute. > -Emil > > [1] > https://github.com/KhronosGroup/EGL-Registry/commit/89be4fbc3ace60f03c0f3b221fff3b6c772bc21e > [2] > http://patchwork.freedesktop.org/bundle/evelikov/explicit-platforms-for-eglplatform/ _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev