Ken,
Did you ever look at this?
--Jason
On August 23, 2017 12:50:25 AM "Pohjolainen, Topi"
<topi.pohjolai...@gmail.com> wrote:
On Tue, Aug 01, 2017 at 03:48:29PM -0700, Jason Ekstrand wrote:
This little series changes things around so that, instead of passing MOCS
values into ISL, ISL knows how to set them itself. This allows us to
centralize some of the decisions about how MOCS gets set for surfaces and
hopefully, if we ever do anything crazy in the future, we can share it
between GL and Vulkan. Unfortunately, surfaces are not the only places
where MOCS is used. It also shows up in vertex buffers, index buffers, and
streamout buffers. However those are always set to the platform equivalent
of I915_MOCS_CACHED (and that's not all that liable to change) so they're
not particularly interesting.
If people like this approach, I'd like to Cc it to stable for 17.2 because
it has the side-effect of making Vulkan MOCS a bit more sane.
Looks like there weren't any input yet. I think this is clearer and less error
prone. So +1 and series:
Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com>
Jason Ekstrand (5):
intel/isl: Set MOCS based on usage for surface states
intel/blorp: Delete the MOCS plumbing
i965: Stop passing MOCS information into ISL
anv: Stop passing MOCS information into ISL
intel/isl: Get rid of the mocs fields in fill/emit_info
src/intel/blorp/blorp.h | 6 ---
src/intel/blorp/blorp_genX_exec.h | 37 +++++++++++------
src/intel/isl/isl.h | 22 ----------
src/intel/isl/isl_emit_depth_stencil.c | 12 +++---
src/intel/isl/isl_genX_mocs.h | 53 ++++++++++++++++++++++++
src/intel/isl/isl_surface_state.c | 9 ++--
src/intel/vulkan/anv_blorp.c | 3 --
src/intel/vulkan/anv_device.c | 1 -
src/intel/vulkan/anv_image.c | 12 ++----
src/intel/vulkan/anv_private.h | 2 -
src/intel/vulkan/genX_cmd_buffer.c | 13 ++----
src/intel/vulkan/genX_state.c | 3 --
src/mesa/drivers/dri/i965/brw_blorp.c | 15 -------
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 26 ++----------
14 files changed, 101 insertions(+), 113 deletions(-)
create mode 100644 src/intel/isl/isl_genX_mocs.h
--
2.5.0.400.gff86faf
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
