On 5 September 2017 at 19:29, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Tue, Sep 5, 2017 at 10:14 AM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> >> Hi Jason, >> >> On 5 September 2017 at 16:48, Jason Ekstrand <ja...@jlekstrand.net> wrote: >> >> > + GLboolean (*queryDmaBufFormatModifierAttribs)(__DRIscreen *screen, >> > + uint32_t fourcc, >> We seems to be using "int fourcc" throughout the file. Worth saying >> consistent and doing the same there? > > > I did, and then Daniel told me to make it uint32_t.
I see his point how - it should be unsigned, even most of the existing code does flips between signed and unsigned. I'm a sucker for consistency, perhaps a bit too much ;-) Either way, the series looks good IMHO Reviewed-by: Emil Velikov <emil.veli...@collabora.com> -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
