Hi Gert, On 10 September 2017 at 12:17, Gert Wollny <gw.foss...@gmail.com> wrote: > Fixes: build failure in travis configuration "make Gallium ST Other" Please use "Fixes: " only with $sha ("commit summary")
> with libunwind enabled (https://travis-ci.org/gerddie/mesa/jobs/273673597) > --- > src/gallium/targets/dri/Makefile.am | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/targets/dri/Makefile.am > b/src/gallium/targets/dri/Makefile.am > index 2d2e1aecec..31148bb54f 100644 > --- a/src/gallium/targets/dri/Makefile.am > +++ b/src/gallium/targets/dri/Makefile.am > @@ -55,7 +55,8 @@ gallium_dri_la_LIBADD = \ > $(SELINUX_LIBS) \ > $(EXPAT_LIBS) \ > $(LIBDRM_LIBS) \ > - $(GALLIUM_COMMON_LIB_DEPS) > + $(GALLIUM_COMMON_LIB_DEPS) \ > + $(LIBUNWIND_LIBS) This doesn't seem right. GALLIUM_COMMON_LIB_DEPS already has $(LIBUNWIND_LIBS) so this change should not be needed. Can you track exactly what's happening. Using `make V=1' will show the full command line. Speaking of which ... some files [1] should include src/gallium/Automake.inc and thus define GALLIUM_COMMON_LIB_DEPS. As-it they all, badly, duplicate it. Thanks Emil [1] src/mesa/state_tracker/tests/Makefile.am src/gallium/targets/osmesa/Makefile.am src/gallium/targets/libgl-xlib/Makefile.am _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev