On Wed, 11 Jan 2012 12:06:36 -0800, Paul Berry <stereotype...@gmail.com> wrote: > Commit 9bdc44a52804a64219a0ca1a061b18596863e524 (i965: Replace struct > with bit shifting for WM pull constant surfaces) accidentally > introduced off-by-one errors into the calculation of the surface > width, height, and depth. This patch restores the correct > computation. > > The reason this wasn't noticed by Piglit tests is that the size of our > constant surfaces is always less than 2^20, therefore the off-by-one > error was causing the "depth" field of the surface to be set to all > 1's. The hardware interpreted this as an extremely large surface, so > overflow checking was effectively disabled. > > No Piglit regressions on Sandy Bridge.
Reviewed-by: Eric Anholt <e...@anholt.net>
pgpjEu4zfscsd.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
