On 04/10/17 00:40, Chad Versace wrote:
On Tue 03 Oct 2017, Jason Ekstrand wrote:
On Tue, Oct 3, 2017 at 3:18 PM, Lionel Landwerlin <[1]
lionel.g.landwer...@intel.com> wrote:

     On 03/10/17 21:21, Chad Versace wrote:

         On Tue 03 Oct 2017, Lionel Landwerlin wrote:

             On 03/10/17 19:13, Jason Ekstrand wrote:

                  +1 to static inline

             Done locally.

         Cool. Waiting to see it appear in wip/djeath/ycbcr_conversion.


     Ah...
     I didn't actually test that (with all the other commits on top).

     Unfortunately that's breaking a bit the way we index formats :

     [4]https://github.com/djdeath/mesa/blob/wip/djdeath/ycbcr_conversion/src/
     intel/vulkan/anv_formats.c#L49


Right... That's a bummer.  Macros it is, I guess.
Fair enough. But please make the macros uppercase, so no one is hurt by
the multiple evaluation.

I updated the branch on github. The first 7 patches should have addressed the review comments.
Still need to deal with array of samplers in the nir pass.

I can resend if you want.

-
Lionel
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to