Hi Gurchetan, 2017-10-18 6:02 GMT+09:00 Gurchetan Singh <gurchetansi...@chromium.org>: > dri2_egl_surface_destroy_image_front and dri2_egl_surface_destroy_image_back > are almost identical. Why don't you just create a > dri2_surface_free_image(struct dri2_egl_surface *dri2_surf, __DRIimage > **img) that you will call with both the front and back images? In addition,
As your opinion, we can rafactor more for dri2_surface_free_image. Nevertheless however, I'd suggest keeping that as separate series. these patches started as a way to minimise the duplication we have in drivers/dri2. So that new platforms such as Tizen do not need to copy the lot. [1] > only platform_android has dri_image_back and dri_image_front -- please keep In this patch, dri2_egl_surface_destroy_image_front() helper is only used for android however it will also be used for new platform (Tizen). [2] [1] https://lists.freedesktop.org/archives/mesa-dev/2017-October/173269.html [2] https://lists.freedesktop.org/archives/mesa-dev/2017-October/172007.html Thanks, Gwan-gyeong _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
