Quoting Eric Engestrom (2017-10-24 08:24:39)
> On Tuesday, 2017-10-24 11:12:49 -0400, Rob Clark wrote:
> > Also needed in freedreno/ir3.
> >
> > Signed-off-by: Rob Clark <robdcl...@gmail.com>
> > ---
> > src/compiler/nir/meson.build | 2 ++
> > src/intel/compiler/meson.build | 2 +-
> > 2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/compiler/nir/meson.build b/src/compiler/nir/meson.build
> > index 144cf01d2c4..4a75c5c8b0d 100644
> > --- a/src/compiler/nir/meson.build
> > +++ b/src/compiler/nir/meson.build
> > @@ -193,6 +193,8 @@ libnir = static_library(
> > build_by_default : false,
> > )
> >
> > +nir_algebraic_py = join_paths(meson.source_root(),
> > 'src/compiler/nir/nir_algebraic.py')
>
> This can be a simple:
> nir_algebraic_py = files('nir_algebraic.py')
>
> > +
> > if with_tests
> > nir_control_flow_test = executable(
> > 'nir_control_flow_test',
> > diff --git a/src/intel/compiler/meson.build b/src/intel/compiler/meson.build
> > index e29e1d39e2a..6a4f016d726 100644
> > --- a/src/intel/compiler/meson.build
> > +++ b/src/intel/compiler/meson.build
> > @@ -122,7 +122,7 @@ brw_nir_trig = custom_target(
> > output : 'brw_nir_trig_workarounds.c',
> > command : [prog_python2, '@INPUT@', '-p',
> > join_paths(meson.source_root(), 'src/compiler/nir/')],
> > - depend_files : files('../../compiler/nir/nir_algebraic.py'),
> > + depend_files : files(nir_algebraic_py),
>
> And this becomes:
> depend_files : nir_algebraic_py,
>
> With that changed:
> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com>I prefer Eric's suggestion as well, with it: Reviewed-by: Dylan Baker <dy...@pnwbakers.com> > > > capture : true, > > ) > > > > -- > > 2.13.6 > > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
signature.asc
Description: signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
