Hi, 2017-10-24 14:46 GMT+02:00 Eric Engestrom <eric.engest...@imgtec.com>: > I had a quick glance, but there's too much at once. > > On Monday, 2017-10-23 17:58:46 +0200, Jerome Duval wrote: >> * configure.ac: >> -pthread is not available on Haiku. >> Haiku doesn't require --enable-dri >> build hgl on Haiku >> * egl/Makefile.am: define backendfiles for Haiku >> * src/gallium/Makefile.am: build winsys/sw/hgl, state_trackers/hgl and >> targets/haiku-softpipe on Haiku. >> * src/gallium/targets/haiku-softpipe: add Makefile.am >> * src/gallium/state_trackers/hgl: add Makefile.am >> * winsys/sw/hgl: add Makefile.am >> * src/hgl/Makefile.am: add Makefile.am > > This list should be a hint: you're doing many things at once :P > Please split this into a series, roughly one patch per item in your > list.
Well that's a patch for a platform, which usually enable components all over the place. > > When doing that, please pay attention to the order of your patches, so > that you don't break anything in the middle (configure.ac probably needs > to be the last patch for instance). I resent as v2. Please consider reviewing. > > Side note: is Meson supported on Haiku? If it is, can you also wire it > up? Or would you be willing to test patches that do? Meson is supported on Haiku (ATM 0.42.1), not my area of expertise though. But sure, I can test patches for Meson. Bye Jerome _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
