On 2 November 2017 at 14:00, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 1 November 2017 at 22:49, Dylan Baker <dy...@pnwbakers.com> wrote: >> Currently the versions are set in the header, and then sed is used to >> extract them, so that autotools can use them elsewhere. >> >> This is odd. Autotools is perfectly capable of configuring the header >> with the versions, and then they don't need to be extracted from the >> the header. This is cleaner and more obvious. >> >> Tested with make distcheck. >> > The idea was to have a place (like VERSION) to grab the version and > reuse across the board. > Since nobody the only other user can handle .in files - it makes sense > to remove the rather nasty construct. > > >> +XA_VERSION_MAJOR=2 >> +AC_SUBST([XA_VERSION_MAJOR]) > Please drop the _VERSION bit and temporary variables. > It make inconsistent with the rest of Mesa. > > AC_SUBST([XA_MAJOR], 2) > AC_SUBST([XA_MINOR], 2) > AC_SUBST([XA_TINY], 0) > I've butchered the numbers - should be 2.3.0
-Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev