Patch series is, Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com>
Sam
On Thu, 2017-11-02 at 21:53 -0700, Jason Ekstrand wrote:
> Now that we're returning a sane type, we can drop the retyping to Q
> in
> nir_emit_load_const.
>
> Cc: Jose Maria Casanova Crespo <jmcasan...@igalia.com>
> ---
> src/intel/compiler/brw_fs_nir.cpp | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/src/intel/compiler/brw_fs_nir.cpp
> b/src/intel/compiler/brw_fs_nir.cpp
> index cbd51a9..0b17e4f 100644
> --- a/src/intel/compiler/brw_fs_nir.cpp
> +++ b/src/intel/compiler/brw_fs_nir.cpp
> @@ -264,7 +264,7 @@ brw_reg_type_from_bit_size(const unsigned
> bit_size,
> case 32:
> return BRW_REGISTER_TYPE_D;
> case 64:
> - return BRW_REGISTER_TYPE_DF;
> + return BRW_REGISTER_TYPE_Q;
> default:
> unreachable("Invalid bit size");
> }
> @@ -277,7 +277,7 @@ brw_reg_type_from_bit_size(const unsigned
> bit_size,
> case 32:
> return BRW_REGISTER_TYPE_UD;
> case 64:
> - return BRW_REGISTER_TYPE_DF;
> + return BRW_REGISTER_TYPE_UQ;
> default:
> unreachable("Invalid bit size");
> }
> @@ -1420,8 +1420,7 @@ fs_visitor::nir_emit_load_const(const
> fs_builder &bld,
> }
> } else {
> for (unsigned i = 0; i < instr->def.num_components; i++)
> - bld.MOV(retype(offset(reg, bld, i),
> BRW_REGISTER_TYPE_Q),
> - brw_imm_q(instr->value.i64[i]));
> + bld.MOV(offset(reg, bld, i), brw_imm_q(instr-
> >value.i64[i]));
> }
> break;
>
signature.asc
Description: This is a digitally signed message part
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
