On 30 November 2017 at 15:13, Jon Turney <jon.tur...@dronecode.org.uk> wrote: > On 29/11/2017 17:34, Dylan Baker wrote: >> >> Quoting Jon Turney (2017-11-29 08:22:54) >>> >>> On 28/11/2017 18:21, Dylan Baker wrote: >>>> >>>> Quoting Emil Velikov (2017-11-27 06:31:35) >>>>> >>>>> IIRC Windows mandates binaries with unresolved symbols. >>>>> Other platforms allow such behaviour. >>>>> >>>>> I think we want to set b_lundef=true, to catch these issues as part of >>>>> the build process. >>>>> We already do so in the autotools, android and at least partially in >>>>> scons. >>>>> >>>>> One would need a workaround for the sanitizers [1] analogous to our >>>>> autotools and scons builds. >>>>> > [...] >>>> >>>> >>>> JFYI, >>>> >>>> b_lundef is true by default, and we don't override it. In this case >>>> (unless I'm >>>> completely misreading/remembering [I wrote a very similar patch in my >>>> macos >>>> branch]), the linkage is correct for Linux (possibly BSD too), but >>>> incorrect for >>>> macOS, Cygwin, and Windows. >>> >>> >>> If this is the case, think this suggests that there's something >>> systematically wrong here, and this isn't the right fix... >>> >>> I'll look into this a bit more. >> >> >> I'm not sure there is anything wrong. with_dri_platfrom == 'drm' will >> always be >> true on Linux/BSD, so really on Linux this patch has no functional >> changes, but >> it will have functional changes in cases where with_dri_platform != 'drm', >> or am >> I missing something? > > > Maybe it's me that's missing something... > > There are references to functions provided by these libraries (xcb_glx, xcb, > x11_xcb) in common code. > Having a reference to those (as printed by the linker as it errors) should help.
There's a lot of macros guarding the different parts of GLX - the obvious ones GLX_ seem there. Another thing that comes to mind is the libloader_dri3_helper. It should be a noop/empty for non-Linux/BSD but something is going wrong? HTH Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev