Hey Tapani,
We had a bit of a discussion on IRC about the patch 2.
Our per context timestamps are 36bits long and so roughly loop around
every 90minutes on gen9.
i965 already knows how to handle the counter wrapping around 36bits.
And since there is no way to measure a more than ~90minutes delta, I
don't think patch 2 is necessary.
Otherwise this series looks good to me (you might want someone else to
double check the API/xml stuff that I'm not super familiar with) :
Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com>
On 20/11/17 07:18, Tapani Pälli wrote:
This series enables mostly existing functionality but adds the disjoint
state required by this extension. WebGL tests seem to utilize desktop
extension GL_EXT_timer_query but I wrote a separate simple Piglit test
for this.
Tapani Pälli (4):
mesa: add DisjointOperation to gl_shared_state
i965: set DisjointOperation true on timestamp overflow
glapi: add GL_EXT_disjoint_timer_query
mesa: enable GL_EXT_disjoint_timer_query extension
src/mapi/glapi/gen/es_EXT.xml | 16 ++++++++++++++++
src/mapi/glapi/gen/gl_API.xml | 4 ++--
src/mesa/drivers/dri/i965/brw_queryobj.c | 4 ++++
src/mesa/main/extensions_table.h | 1 +
src/mesa/main/get.c | 17 +++++++++++++++++
src/mesa/main/get_hash_params.py | 5 +++++
src/mesa/main/glheader.h | 4 ++++
src/mesa/main/mtypes.h | 9 +++++++++
src/mesa/main/queryobj.c | 3 ++-
src/mesa/main/robustness.c | 1 +
src/mesa/main/tests/dispatch_sanity.cpp | 5 +++++
11 files changed, 66 insertions(+), 3 deletions(-)
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
