Any chance to wrap up this review? Thanks!
Eduardo On 12/13/2017 08:32 PM, Eduardo Lima Mitev wrote: > Hi, > > This is the 3rd version of the series adding initial support for ARB_gl_spirv. > > Previous versions of this series included also support for > ARB_spirv_extensions, but we have decided to split the two to ease review. So > I will be sending a second series with only the patches for spirv_extensions. > > Notice also that some patches from version 2 were merged in master. These > were already reviewed favorably and were fairly independent from the rest of > the series. > > There are still some patches in this new series with a Reviewed-by tag that > we didn't merge yet because we consider they should go in with the rest of > the series. The patches missing review are 01, 02, 03, 04 and 07. > > As usual, a git tree containing this series can be found at > <https://github.com/Igalia/mesa/tree/arb_gl_spirv-series1-v3> and the larger, > work-in-progress series at > <https://github.com/Igalia/mesa/tree/wip/igalia/arb_gl_spirv>. > > Thanks for reviewing! > > cheers, > Eduardo > > Alejandro Piñeiro (2): > i965: initialize SPIR-V capabilities > nir/spirv: add gl_spirv_validation method > > Eduardo Lima Mitev (6): > mesa: Add a reference to gl_shader_spirv_data to gl_linked_shader > mesa/glspirv: Add _mesa_spirv_link_shaders() function > mesa/program: Link SPIR-V shaders using the SPIR-V code-path > mesa/glspirv: Add a _mesa_spirv_to_nir() function > i965: Call spirv_to_nir() instead of glsl_to_nir() for SPIR-V shaders > i965: Don't call process_glsl_ir() for SPIR-V shaders > > Nicolai Hähnle (2): > mesa: add gl_constants::SpirVCapabilities > mesa: Implement glSpecializeShaderARB > > src/compiler/spirv/nir_spirv.h | 5 + > src/compiler/spirv/spirv_to_nir.c | 191 +++++++++++++++++++++++--- > src/mesa/drivers/dri/i965/brw_context.c | 20 +++ > src/mesa/drivers/dri/i965/brw_link.cpp | 3 +- > src/mesa/drivers/dri/i965/brw_program.c | 10 +- > src/mesa/main/glspirv.c | 236 > +++++++++++++++++++++++++++++++- > src/mesa/main/glspirv.h | 11 ++ > src/mesa/main/mtypes.h | 11 ++ > src/mesa/main/shaderobj.c | 1 + > src/mesa/program/ir_to_mesa.cpp | 6 +- > 10 files changed, 472 insertions(+), 22 deletions(-) > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
