Quoting Greg V (2017-12-31 08:55:22)
> ---
>  meson.build | 43 ++++++++++++++++++++++---------------------
>  1 file changed, 22 insertions(+), 21 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index d9f7ea9b2c..af62baf437 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -199,12 +199,13 @@ if with_dri_i915 or with_gallium_i915
>    dep_libdrm_intel = dependency('libdrm_intel', version : '>= 2.4.75')
>  endif
>  
> +is_like_linux = host_machine.system() == 'linux' or 
> host_machine.system().contains('bsd') # FIXME: illumos?

This won't cover dragonflybsd, which is just 'dragonfly'

I think something like this would be better:
is_like_linux = ['openbsd', 'netbsd', 'freebsd', 'dragonfly', 
'linux'].contains(host_machine.system())

I'd like to know what illumos returns, but I can't get it to run in VM. If you
have access to an illumos machine, getting the result of:
`python3 -c "import platform; print(platform.system().lower())"` so we can add
that to meson's support os values.

As a nit, I'd prefer "system_is_linux_like" to just "is_like_linux" but I'm not
set on that like the first change.

I'd kinda like to add a meson.system_family() for covering these kind of cases,
but I'm not sure I'm going to get to it any time soon :)

Dylan

Attachment: signature.asc
Description: signature

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to