On 15.01.2018 15:15, Samuel Thibault wrote:
Nicolai Hähnle, on lun. 15 janv. 2018 15:07:03 +0100, wrote:
On 13.01.2018 12:36, Samuel Thibault wrote:
glXGetDriverConfig parameters do not provide a context to dynamically
check for the presence of the function, so the dispatcher directly calls
glXGetDriverConfig, but in non-dri builds dri_glx.c didn't provide
glXGetDriverConfig.
This change makes it provide a NULL-returning stub in non-dri builds.
Fixes: 84f764a7591 "glxglvnddispatch: Add missing dispatch for GetDriverConfig"
Would it be possible to instead modify dispatch_GetDriverConfig with an:
#if defined(GLX_DIRECT_RENDERING) && !defined(GLX_USE_APPLEGL)
...
#else
return NULL;
#endif
Sure! There is just one thing: src/glx/g_glxglvnddispatchfuncs.c reads
* THIS FILE IS AUTOMATICALLY GENERATED BY gen_scrn_dispatch.pl
* DO NOT EDIT!!
I didn't find that script...
Good point.
Then again, that file isn't actually generated as part of the build (and
as you write, that Perl script is missing), and the problem you're
trying to fix originates in a manual edit of that file.
So I vote to fix this by changing the original manual edit, though I'd
welcome other suggestions, especially ones that fix the confusion around
whether that file is automatically generated...
Cheers,
Nicolai
Samuel
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
