On 01/19/2018 16:30, Eric Engestrom wrote:
On Wednesday, 2018-01-17 23:54:15 +0300, Greg V wrote:
Reviewed-by: Dylan Baker <dy...@pnwbakers.com>
A couple questions and a nit-pick for the error messages, but with that:
Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com>
@@ -225,7 +227,7 @@ with_platform_surfaceless = false
egl_native_platform = ''
_platforms = get_option('platforms')
if _platforms == 'auto'
- if ['linux'].contains(host_machine.system())
+ if system_has_kms_drm
_platforms = 'x11,wayland,drm,surfaceless'
Are we sure we want all those on *BSD?
Yes.
OpenBSD and NetBSD might want to skip wayland, since they don't seem to
have evdev and stuff (yet?).
But they can turn it off in ports, I don't think we need to add extra
conditions here.
FreeBSD and DragonFly do want ALL THE THINGS though :)
else
error('Unknown OS, no platforms enabled. Patches gladly accepted to fix
this.')
@@ -272,9 +274,9 @@ endif
with_gbm = get_option('gbm')
if with_gbm == 'auto' and with_dri # TODO: or gallium
- with_gbm = host_machine.system() == 'linux'
+ with_gbm = system_has_kms_drm
elif with_gbm == 'true'
- if not ['linux', 'bsd'].contains(host_machine.system())
+ if not system_has_kms_drm
error('GBM only supports unix-like platforms')
Change the error message to something like this?
GBM only supports DRM/KMS OSs
Sure.
elif not (with_gallium_nouveau or with_gallium_freedreno or
with_gallium_i915
or with_gallium_svga)
@@ -711,7 +713,7 @@ if cc.compiles('int foo(void)
__attribute__((__noreturn__));',
endif
# TODO: this is very incomplete
-if ['linux', 'cygwin'].contains(host_machine.system())
+if system_has_kms_drm or host_machine.system() == 'cygwin'
pre_args += '-D_GNU_SOURCE'
Do *BSD use _GNU_SOURCE ?
No, it does nothing of course. *facepalm* that was totally unnecessary,
I'll remove it
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
