Quoting Elie Tournier (2018-02-01 12:13:53) > On Thu, Feb 01, 2018 at 10:00:12AM -0800, Dylan Baker wrote: > > There are changes from Makefile.sources that need be ported to corresponding > > meson.build files as well. > Oh yes, nice spot. I will do it on my local fp64 branch too. > > > > It looks like builtin_float64.h is generated from float64.glsl, is that > > right? > Like builtin_int64h and int64.glsl, builtin_float64.h is generated from > float64.glsl. > > > I'm not very happy about checking in a generated file for all of the reasons > > that we don't check generated files in. I recognize that trying to generate > > code > > from an in tree binary at compile time makes the cross compiling situation > > less > > than ideal since we would need to bootstrap the glsl compiler, but it's > > still > > annoying. This is why we stopped using glsl compilation for mesa, and added > > tools like nir_builder and ir_builder. I guess that's a pretty big > > complaint and > > I don't expect you to fix it, but it's frustrating that we're going to have > > to > > check generated code in and deal with all the problems that come along with > > that. > This project is quite big. Using ir_builder would make this project even > bigger. > At least for me. ;)
Yeah, I understand that. :)
signature.asc
Description: signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev