On Sunday, 2018-01-28 14:18:27 +0000, Jon Turney wrote: > mesa/src/glx/glxcmds.c:1295:21: error: implicit declaration of function > 'env_var_as_boolean' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > mesa/src/glx/apple/apple_visual.c:85:28: error: implicit declaration of > function 'env_var_as_boolean' is invalid in C99 > [-Werror,-Wimplicit-function-declaration]
Oops, these are mine :( Fixes: 3fdbc46b42dcfd3af52d8 "glx: turn LIBGL_DUMP_VISUALID into a boolean" Fixes: d2768a397d6fb8a094765 "glx: turn LIBGL_PROFILE_CORE into a boolean" Fixes: 5c68ea29f31283768c8e1 "egl+glx: turn LIBGL_ALWAYS_SOFTWARE into a boolean" Fixes: 43e2d58698f76b96b36ff "glx: turn LIBGL_ALLOW_SOFTWARE into a boolean" Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > src/glx/apple/apple_visual.c | 1 + > src/glx/glxcmds.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/src/glx/apple/apple_visual.c b/src/glx/apple/apple_visual.c > index d482bfc4e71..4a90d77c3a5 100644 > --- a/src/glx/apple/apple_visual.c > +++ b/src/glx/apple/apple_visual.c > @@ -32,6 +32,7 @@ > #include <stdlib.h> > #include <assert.h> > #include <GL/gl.h> > +#include <util/debug.h> Nit: use "" instead of <> for local includes :) > > /* <rdar://problem/6953344> */ > #define glTexImage1D glTexImage1D_OSX > diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c > index eee45d962d7..943b81754f3 100644 > --- a/src/glx/glxcmds.c > +++ b/src/glx/glxcmds.c > @@ -43,6 +43,7 @@ > #ifdef GLX_USE_APPLEGL > #include "apple/apple_glx_context.h" > #include "apple/apple_glx.h" > +#include "util/debug.h" > #else > #include <sys/time.h> > #ifdef XF86VIDMODE > -- > 2.15.1 > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
