On 2017-10-24 11:47, Emil Velikov wrote:
Hi Jerome,

On 23 October 2017 at 16:58, Jerome Duval <jerome.du...@gmail.com> wrote:
* configure.ac:
  -pthread is not available on Haiku.
  Haiku doesn't require --enable-dri
  build hgl on Haiku
* egl/Makefile.am: define backendfiles for Haiku
* src/gallium/Makefile.am: build winsys/sw/hgl, state_trackers/hgl and
targets/haiku-softpipe on Haiku.
* src/gallium/targets/haiku-softpipe: add Makefile.am
* src/gallium/state_trackers/hgl: add Makefile.am
* winsys/sw/hgl: add Makefile.am
* src/hgl/Makefile.am: add Makefile.am
---
Thanks for the patch. I think Eric has a point regarding splitting this up.
Here is one way to handle it:
 - patch 1 - the driver, aka st/hgl + sw/hgl + targets/haiku
 - 2 - src/egl
 - 3 - src/hgl
 - 4 misc fixes (the SoftwareRenderer.cpp hunk?)
 - 5 toggle - configure.ac + src/Makefile.am

Hm, it looks like Jerome never got back to work on these changes... let me try to
pick up the ball and run with it.

Couple of small suggestions:
- keep all the sources and headers in the sources lists in Makefile.sources - how do you guys manage pthreads - please mention that in the commit message.

If I'm reading this correctly, you strip out -pthread and there's no
pthread-stubs on Haiku.

Haiku (and BeOS for that matter) has pthread support built into its core libroot.so.

No need for -lpthread, all applications can assume its presence. Things that link -lpthread actually fail due to a non-existant libpthread... *however* as i'm typing this i'm being told we recently implemented a dummy static libpthread.a to try and appease assumptions about -lpthread existence.... so i'll remove the pthread checks :-)

 -- Alex
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to