Quoting Emil Velikov (2018-02-08 14:51:57) > On 2 February 2018 at 21:42, Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> > wrote: > > On Fri, Feb 2, 2018 at 10:31 PM, Dylan Baker <dy...@pnwbakers.com> wrote: > >> Quoting Bas Nieuwenhuizen (2018-02-02 10:14:04) > >>> On Fri, Feb 2, 2018 at 6:59 PM, Emil Velikov <emil.l.veli...@gmail.com> > >>> wrote: > >>> > Hi Bas, > >>> > > >>> > On 31 January 2018 at 11:31, Bas Nieuwenhuizen <ba...@chromium.org> > >>> > wrote: > >>> >> deqp does not allow any KHX extensions, and since deqp is included > >>> >> in android-cts, android does not allow any khx extensions. > >>> >> > >>> >> So disable VK_KHX_multiview on android. > >>> >> --- > >>> >> src/amd/vulkan/radv_extensions.py | 2 +- > >>> >> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> >> > >>> >> diff --git a/src/amd/vulkan/radv_extensions.py > >>> >> b/src/amd/vulkan/radv_extensions.py > >>> >> index ab34c01cb6..e6c6e63627 100644 > >>> >> --- a/src/amd/vulkan/radv_extensions.py > >>> >> +++ b/src/amd/vulkan/radv_extensions.py > >>> >> @@ -81,7 +81,7 @@ EXTENSIONS = [ > >>> >> Extension('VK_KHR_wayland_surface', 6, > >>> >> 'VK_USE_PLATFORM_WAYLAND_KHR'), > >>> >> Extension('VK_KHR_xcb_surface', 6, > >>> >> 'VK_USE_PLATFORM_XCB_KHR'), > >>> >> Extension('VK_KHR_xlib_surface', 6, > >>> >> 'VK_USE_PLATFORM_XLIB_KHR'), > >>> >> - Extension('VK_KHX_multiview', 1, True), > >>> >> + Extension('VK_KHX_multiview', 1, > >>> >> '!ANDROID'), > >>> > > >>> > While picking the patch for stable the following questions came to > >>> > mind. Hope you can you shed some light. > >>> > > >>> > Is this restriction effectively a Vulkan loader limitation or ? > >>> > Should we use the same for the Intel Vulkan driver as well? > >>> > >>> The testsuite Android conformance testing (deqp as part of Android > >>> CTS) is slightly stricter than the vulkan-CTS. So enabling it results > >>> in a perfectly working extension, but you just don't have a conformant > >>> Android device. > >>> > >>> I think Chad expected the KHX extensions to be disabled in all > >>> releases, as far as I can tell they have not for the past few > >>> releases, so I'm not entirely sure what is supposed to happen here. > >>> I'd expect this would be needed by Intel too, but given that the Intel > >>> driver has been tested for Android for a while and this is not in the > >>> Intel driver yet, I'm probably overlooking their solution. > >>> > >>> - Bas > >>> > >>> > >>> > > >>> > Thanks > >>> > Emil > >>> > _______________________________________________ > >> > >> Our plan is (and has been) to disable VK_KHX extensions in release > >> branches, but > >> leave them on in development snapshots, regardless of whether we're > >> running on > >> Android or !Android. If KHX extensions are on in the release branch that's > >> a bug > >> and we need to fix it before shipping a release. > > > > Looks like it is still enabled in 17.3 and 18.0 (though that is not > > really released yet), but disabled in 17.2. > > > You're right. Jason sent a patch for 17.2 but we missed one for the > later stable branches. > I've adapted it and queued to both. > > -Emil
Thanks for doing that.
signature.asc
Description: signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev