I just checked what Rise of the Tomb Raider is using. Maximum it hits for uniform buffers is 15, and 6 for storage buffers. The highest combined total is 15.
Alex On 2 March 2018 at 20:11, Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> wrote: > Hi Alex, > > How many do you need of either type? > > - Bas > > On Fri, Mar 2, 2018 at 4:28 PM, Alex Smith <asm...@feralinteractive.com> > wrote: > > These were set to MAX_DYNAMIC_BUFFERS / 2, which is too restrictive > > since an app may have it's total usage of both uniform and storage > > within MAX_DYNAMIC_BUFFERS, but exceed the limit for one of the types. > > > > Recently the validation layers have started raising errors for when > > these limits are exceeded, so these are firing for something that > > actually works just fine. > > > > Set the limit for both to MAX_DYNAMIC_BUFFERS. Not ideal because it > > now allows the total across both to exceed the real limit, but we have > > no way to express that limit properly. > > > > Cc: <mesa-sta...@lists.freedesktop.org> > > Signed-off-by: Alex Smith <asm...@feralinteractive.com> > > --- > > src/amd/vulkan/radv_device.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c > > index 36d7a406bf..1e81ddb891 100644 > > --- a/src/amd/vulkan/radv_device.c > > +++ b/src/amd/vulkan/radv_device.c > > @@ -717,9 +717,9 @@ void radv_GetPhysicalDeviceProperties( > > .maxPerStageResources = > max_descriptor_set_size, > > .maxDescriptorSetSamplers = > max_descriptor_set_size, > > .maxDescriptorSetUniformBuffers = > max_descriptor_set_size, > > - .maxDescriptorSetUniformBuffersDynamic = > MAX_DYNAMIC_BUFFERS / 2, > > + .maxDescriptorSetUniformBuffersDynamic = > MAX_DYNAMIC_BUFFERS, > > .maxDescriptorSetStorageBuffers = > max_descriptor_set_size, > > - .maxDescriptorSetStorageBuffersDynamic = > MAX_DYNAMIC_BUFFERS / 2, > > + .maxDescriptorSetStorageBuffersDynamic = > MAX_DYNAMIC_BUFFERS, > > .maxDescriptorSetSampledImages = > max_descriptor_set_size, > > .maxDescriptorSetStorageImages = > max_descriptor_set_size, > > .maxDescriptorSetInputAttachments = > max_descriptor_set_size, > > -- > > 2.14.3 > > > > _______________________________________________ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
