On Thursday, 2018-03-08 10:04:03 -0800, Keith Packard wrote: > Eric Engestrom <eric.engest...@imgtec.com> writes: > > > I'm still slightly bothered by the build options inconsistency between > > autotools: reuse --with-platform=drm > > meson: new -D platform=display > > > > I'd be happy with either one being used everywhere, but from what you > > said last time I think you'd prefer to reuse `platform=drm`; can we > > drop the meson hunks above and use `with_platform_drm` in > > src/vulkan/wsi/meson.build? > > Thanks for the reminder; I got totally bound up in Jason's code fixes > and rebasing onto current master that I just forgot. I've got three tiny > patches on my drm-lease-v2 branch which does this (one for core, one for > anv, one for radv). > > > About that hunk, have you looked at my patch? > > https://patchwork.freedesktop.org/patch/206818/ > > Yeah, that definitely looks nicer. I've reviewed it to make sure calling > the various finish functions is harmless when called before the matching > init function. If it gets applied before my series, I'll adapt :-)
I just pushed it; your `if (result != VK_SUCCESS)` should now just be `goto fail;` :) > > -- > -keith _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev