On 12 March 2018 at 14:33, Eric Engestrom <eric.engest...@imgtec.com> wrote: > We're trying to be -Wundef clean so that we can turn it on (and > eventually make it an error). > > Note that the OMX code already used `#if ENABLE_ST_OMX_BELLAGIO` instead > of #ifdef; I could've changed these, but the point of -Wundef is to > catch typos, so we might as well make the change the right way. > > Fixes: 83d4a5d5aea5a8a05be2 "st/omx/tizonia: Add H.264 decoder" > Fixes: b2f2236dc565dd1460f0 "st/omx/tizonia: Add H.264 encoder" > Fixes: c62cf1f165919bc74296 "st/omx/tizonia/h264d: Add EGLImage support" > Cc: Gurkirpal Singh <gurkirpal...@gmail.com> > Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > The meson hunk doesn't look pretty at all, but I'm planning on replacing > all the `pre_args` with a configuration_data(), which will allow to > simplify a lot of this #defines code.
The meson hunk doesn't look that bad IMHO. Reviewed-by: Emil Velikov <emil.veli...@collabora.com> Thanks Emil P.S. The re-spinned upstream gtest patches, seems to have fallen through the cracks again :-\ _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
