On March 16, 2018 5:49:12 PM UTC, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 16 March 2018 at 15:58, Eric Engestrom <eric.engest...@imgtec.com> > wrote: > > This pulls in commit a93f559e9c11fa53fb5f1cc255b8f75433f85d2a "Add > Ozone > > section to eglplatform.h" from Khronos [1] added by Brian Anderson > [2] > > a few months ago. > > > > [1] > https://github.com/KhronosGroup/EGL-Registry/commit/a93f559e9c11fa53fb5f1cc255b8f75433f85d2a > > [2] https://github.com/KhronosGroup/EGL-Registry/pull/26 > > > > Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> > > --- > > include/EGL/eglplatform.h | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/include/EGL/eglplatform.h b/include/EGL/eglplatform.h > > index bf9ec0bf5f4fbf7105cd..8a78a9eaddd2f47ff2c0 100644 > > --- a/include/EGL/eglplatform.h > > +++ b/include/EGL/eglplatform.h > > @@ -104,6 +104,12 @@ typedef struct ANativeWindow* > EGLNativeWindowType; > > typedef struct egl_native_pixmap_t* EGLNativePixmapType; > > typedef void* EGLNativeDisplayType; > > > > +#elif defined(USE_OZONE) > > + > > +typedef intptr_t EGLNativeDisplayType; > > +typedef intptr_t EGLNativeWindowType; > > +typedef intptr_t EGLNativePixmapType; > > + > Eek, that looks nasty - signed intptr_t insteaf of the default void* + > uintptr_t.
Yeah, I don't like it either, but it's what Google chose to push. > > Which reminds me - need to join the EGL WG meetings and get > EGL_USE_PLATFORM_* sorted [1]. Oh, I remember that series, why did you not land it? (The first part of it anyway) Looking forward to "seeing" you on these calls :) > Until then, the series looks good and is > > Reviewed-by: Emil Velikov <emil.veli...@collabora.com> Thanks! > > -Emil > > [1] https://patchwork.freedesktop.org/series/12778/ > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev