Jason Ekstrand <ja...@jlekstrand.net> writes:

> They are send messages and this makes size_written() and mlen agree.

You mean size_read()?  And commit message should probably read "Return
mlen * 32 for size_read for INTERPOLATE_AT_*" to reflect what the commit
is doing.

> For both of these opcodes, the payload is just a dummy so mlen == 1 and
> this should decrease register pressure a bit.
>

Reviewed-by: Francisco Jerez <curroje...@riseup.net>

> Cc: Francisco Jerez <curroje...@riseup.net>
> Cc: mesa-sta...@lists.freedesktop.org
> ---
>  src/intel/compiler/brw_fs.cpp | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp
> index 40896db..8156507 100644
> --- a/src/intel/compiler/brw_fs.cpp
> +++ b/src/intel/compiler/brw_fs.cpp
> @@ -842,6 +842,8 @@ fs_inst::size_read(int arg) const
>     case SHADER_OPCODE_TYPED_ATOMIC:
>     case SHADER_OPCODE_TYPED_SURFACE_READ:
>     case SHADER_OPCODE_TYPED_SURFACE_WRITE:
> +   case FS_OPCODE_INTERPOLATE_AT_SAMPLE:
> +   case FS_OPCODE_INTERPOLATE_AT_SHARED_OFFSET:
>     case FS_OPCODE_INTERPOLATE_AT_PER_SLOT_OFFSET:
>     case SHADER_OPCODE_BYTE_SCATTERED_WRITE:
>     case SHADER_OPCODE_BYTE_SCATTERED_READ:
> -- 
> 2.5.0.400.gff86faf

Attachment: signature.asc
Description: PGP signature

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to