Hi;

On 05/01/2018 05:48 PM, Christian Gmeiner wrote:
Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com>
Reviewed-by: Wladimir J. van der Laan <laa...@gmail.com>
---
  src/mesa/main/glformats.c | 19 +++++++++++++++++++
  1 file changed, 19 insertions(+)

diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index cba5e670db..1d3d524875 100644
--- a/src/mesa/main/glformats.c
+++ b/src/mesa/main/glformats.c
@@ -2424,6 +2424,25 @@ _mesa_base_tex_format(const struct gl_context *ctx, 
GLint internalFormat)
           return GL_YCBCR_MESA;
     }
+ if (ctx->Extensions.OES_texture_half_float) {

this could be

if ((ctx->Extensions.ARB_texture_float) ||
  ctx->Extensions.OES_texture_half_float))

+       switch (internalFormat) {
+       case GL_ALPHA16F_ARB:
+          return GL_ALPHA;
+       case GL_RGBA16F_ARB:
+          return GL_RGBA;
+       case GL_RGB16F_ARB:
+          return GL_RGB;
+       case GL_INTENSITY16F_ARB:
+          return GL_INTENSITY;
+       case GL_LUMINANCE16F_ARB:
+          return GL_LUMINANCE;
+       case GL_LUMINANCE_ALPHA16F_ARB:
+          return GL_LUMINANCE_ALPHA;
+       default:
+          ; /* fallthrough */
+       }
+   }
+

It seems like we miss OES_texture_float as well .. with the above change (separation of half float formats from full float ones) we could have a OES_texture_float || ARB_texture_float check for the rest?


     if (ctx->Extensions.ARB_texture_float) {
        switch (internalFormat) {
        case GL_ALPHA16F_ARB:


// Tapani
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to