Hi, sorry for the delay. I thought maybe Emil is on holiday. I plan to push this on Monday evening (EDT) if there is no response by then.
Jan On Sun, May 13, 2018 at 3:56 AM, Kai Wasserbäch <k...@dev.carbon-project.org> wrote: > Ping! Can somebody *please* commit this patch? It fixes an FTBFS, has two > T-b > and one A-b. > > > Kai Wasserbäch wrote on 07.05.2018 16:48: > > Jan Vesely wrote on 02.05.2018 22:38: > >> On Wed, 2018-05-02 at 18:38 +0200, Kai Wasserbäch wrote: > >>> [...] > >> > >> Thank for looking into this. We probably need CLANG_LIBS handling > >> similar to LLVM_LIBS. I agree this is the best fix for now. > >> > >> Acked-by: Jan Vesely <jan.ves...@rutgers.edu> > >> > >> libclang.so might be a solkution, but I'm not sure how it interacts > >> with older or static build clang. It's also weird that we are linking > >> to clang here instead of clover which actually uses clang symbols. > >> > >> @Emil, are you OK with this patch? > > > > Gentle ping. > > > >>>>>>> -lclangDriver \ > >>>>>>> -lclangSerialization \ > >>>>>>> - -lclangCodeGen \ > >>>>>> > >>>>>> Is this change related? > >>>>> > >>>>> Not really, just a minor clean-up while I was busy a few lines above. > >>>>> "clangCodeGen" is already named on the first Clang library line. > >>>> > >>>> ah, all right, maybe mention it in the commit message? > >>> > >>> Do I need to resend the patch for that or can you just add a line like > "This > >>> change also removes the duplicate clangCodeGen line (trivial change)." > before > >>> pushing, considering, that there are two T-b tags to be added anyway? > >> > >> I'll add it on my side before pushing the patch. > > > > Thanks a lot! > > > > Cheers, > > Kai > > > > > > > > _______________________________________________ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > > > > -- > > Kai Wasserbäch (Kai Wasserbaech) > > E-Mail: k...@dev.carbon-project.org > >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
