Hi there, 2018-04-22 15:36 GMT+02:00 Stefan Schake <stsch...@gmail.com>:
> On Sun, Apr 22, 2018 at 1:11 PM, Mauro Rossi <issor.or...@gmail.com> > wrote: > > Fix for build errors in src/gallium/auxiliary/util/u_ > debug_stack_android.cpp > > error: cast to 'void *' from smaller integer type pid_t > > > > Fixes: ff904978a1 ("gallium/util: Android backtrace support") > > > > Cc: "18.1" <mesa-sta...@lists.freedesktop.org> > > --- > > src/gallium/auxiliary/util/u_debug_stack_android.cpp | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/src/gallium/auxiliary/util/u_debug_stack_android.cpp > b/src/gallium/auxiliary/util/u_debug_stack_android.cpp > > index b3d56aebe6..11e2d3962b 100644 > > --- a/src/gallium/auxiliary/util/u_debug_stack_android.cpp > > +++ b/src/gallium/auxiliary/util/u_debug_stack_android.cpp > > @@ -49,10 +49,10 @@ debug_backtrace_capture(debug_stack_frame > *mesa_backtrace, > > backtrace_table = _mesa_hash_table_create(NULL, > _mesa_hash_pointer, > > > _mesa_key_pointer_equal); > > > > - backtrace_entry = _mesa_hash_table_search(backtrace_table, (void*) > tid); > > + backtrace_entry = _mesa_hash_table_search(backtrace_table, > (void*)(uintptr_t) tid); > > if (!backtrace_entry) { > > backtrace = Backtrace::Create(getpid(), tid); > > - _mesa_hash_table_insert(backtrace_table, (void*) tid, backtrace); > > + _mesa_hash_table_insert(backtrace_table, (void*)(uintptr_t) tid, > backtrace); > > } else { > > backtrace = (Backtrace *) backtrace_entry->data; > > } > > -- > > 2.14.1 > > > > Sorry, I'm doing ARMv7/32-bit builds so this slipped through. > > Reviewed-By: Stefan Schake <stsch...@gmail.com> > > Thanks! > May I ask a second review by for intel x86 based platforms to Emil or other developer in Cc: ? Thanks Mauro
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev