On Tuesday, June 12, 2018 12:44:44 PM PDT Kenneth Graunke wrote: > On Thursday, May 31, 2018 10:01:43 PM PDT Jason Ekstrand wrote: > > Ideally, I'd like the series to get some amount of real review before it > > lands. Honestly, it's been baking long enough and tested by enough people > > on enough drivers that we can probably throw a bunch of Acked-by and > > Tested-bys on it and call it a day but I'd rather not. I plan to review > > all of the patches I didn't write but that will have to wait until > > tomorrow. > > > > At the very least, I'd like some sort of an ACK from a variety of the > > people that use NIR on the core concept and the sort of general shape of > > things at the end of the series. A lot of work has gone into this but it's > > also a big change and the more positive feedback it gets, the more > > comfortable I'll be pulling the trigger. > > Patches 1-28 are > Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
Patches 1-105 and 123-129 are: Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> Patch 106 (opt_copy_prop_vars) is also R-b assuming that you fix the bug that I pointed out in my reply there. I ran out of energy for reviewing the ac/radv/radeonsi patches...not sure anyone really needs me to anyway. I think you're good to go on this series, at least from my point of view.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev