On 26 July 2018 at 16:32, Mauro Rossi <issor.or...@gmail.com> wrote: > Hello there, > Il giorno gio 26 lug 2018 alle ore 17:09 Mauro Rossi > <issor.or...@gmail.com> ha scritto: >> >> Hi Emil, >> >> Il giorno gio 26 lug 2018 alle ore 16:48 Emil Velikov >> <emil.l.veli...@gmail.com> ha scritto: >> > >> > On 22 July 2018 at 09:14, Mauro Rossi <issor.or...@gmail.com> wrote: >> > > radv implements the Android Vulkan HAL interface, this patch adds >> > > Android.mk building rules by porting of radv automake rules. >> > > vendor HAL module is installed as /vendor/lib/hw/vulkan.radv.so >> > > >> > > Signed-off-by: Mauro Rossi <issor.or...@gmail.com> >> > > --- >> > > src/amd/vulkan/Android.mk | 166 ++++++++++++++++++++++++++++++++++++++ >> > >> > It would be great it this file is a bit closer to the ANV one, >> > although no clever ideas come to mind. >> >> As a Quick Win, I think I could pull up this of one level as >> src/amd/Android.vulkan.mk, >> perform the necessary changes in paths, modify 4/4 accordingly, >> test build and no regression and then and push to gitlab with those changes. >> >> No problem to do that. >> >> Please, let me know if I may send 3/4 and 4/4 for review >> to you, to avoid resubmitting and re-reviewing the full series. >> >> Is it ok for you? >> Mauro > > Well, I was too optimistic and considering only Android building rules, > it would require to modify also the automake rules and Makefile.sources > to accomodate the change in the relative path. > > At least the automake and Android for radv are aligned in the AS-IS serie. > > We can align radv to anv with another patch, but it is better to check > also with AMD developers that they agree to it. > Agreed - series seems fine as-is. Any extra tweaks can be done at a later stage.
-Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev