Hi, On Thu, 26 Jul 2018 at 19:53, Eric Anholt <e...@anholt.net> wrote: > > Olivier Fourdan <ofour...@redhat.com> writes: > > > get_supported_modifiers() and pixmap_from_buffers() requests both > > expect a window as drawable, passing a pixmap will fail as the Xserver > > will fail to match the given drawable to a window. > > > > That leads to dri3_alloc_render_buffer() to return NULL and breaks > > rendering when using GLX_DOUBLEBUFFER on pixmaps. > > > > Query the root window of the pixmap on first init, and use the root > > window instead of the pixmap drawable for get_supported_modifiers() > > and pixmap_from_buffers(). > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107117 > > Fixes: 069fdd5 ("egl/x11: Support DRI3 v1.1") > > Signed-off-by: Olivier Fourdan <ofour...@redhat.com> > > Looks great! > > Reviewed-by: Eric Anholt <e...@anholt.net>
Thanks both Daniel and Eric for the reviews! If I may, could someone push that fix for me, I don't think I have commit rights in Mesa... (It's a regression affecting Mesa 18.1 with Xserver 1.20, would be great to have it fixed) Cheers, Olivier _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
