This is a really nice tool, and I'm looking forward to see the other
features you teased us with, as well as helping to improve it.

With that said, I don't know much about the imgui API and can't really
do much to help reviewing it yet. But I would like to have it landed
anyway.

Patches 13 and 14 are:

Acked-by: Rafael Antognolli <rafael.antogno...@intel.com> 

On Thu, Aug 02, 2018 at 10:39:25AM +0100, Lionel Landwerlin wrote:
> A graphical user interface version of aubinator.
> Allows you to :
> 
>    - simultaneously look at multiple points in the aub file (using all
>      the goodness of the existing decoding in aubinator)
> 
>    - edit an aub file
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com>
> ---
>  src/intel/tools/aubinator_viewer.cpp         | 1173 ++++++++++++++++++
>  src/intel/tools/aubinator_viewer.h           |   61 +
>  src/intel/tools/aubinator_viewer_decoder.cpp |  849 +++++++++++++
>  src/intel/tools/imgui/imgui_memory_editor.h  |  426 +++++++
>  src/intel/tools/meson.build                  |   13 +
>  5 files changed, 2522 insertions(+)
>  create mode 100644 src/intel/tools/aubinator_viewer.cpp
>  create mode 100644 src/intel/tools/aubinator_viewer.h
>  create mode 100644 src/intel/tools/aubinator_viewer_decoder.cpp
>  create mode 100644 src/intel/tools/imgui/imgui_memory_editor.h
> 
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to