On 08/06/2018 10:02 AM, Dylan Baker wrote:
> Add dispatch_sanity tests
>
> Fixes: 3d6900d76efaef1ff6e84b7b8785bbe3d8f5b29b
> ("glapi: define AMD_framebuffer_multisample_advanced and add its
> functions")
> Cc: Marek Olšák <marek.ol...@amd.com>
> Cc: Brian Paul <bri...@vmware.com>
> Signed-off-by: Dylan Baker <dylan.c.ba...@intel.com>
> ---
>
> Marek, the XML in mesa and the Khronos XML agree that this works for GLES 2.0,
> but the spec says 3.0. I assume the spec is wrong and should be corrected?
Something more than "just" 2.0 is needed because GLES 2.0 doesn't have
framebuffer objects. I suspect that's the reason for the 3.0
requirement. It sounds more like the Khronos XML is wrong. I already
changed Mesa's XML.
> src/mesa/main/tests/dispatch_sanity.cpp | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/src/mesa/main/tests/dispatch_sanity.cpp
> b/src/mesa/main/tests/dispatch_sanity.cpp
> index 82eb61dcf73..b395a09e13f 100644
> --- a/src/mesa/main/tests/dispatch_sanity.cpp
> +++ b/src/mesa/main/tests/dispatch_sanity.cpp
> @@ -1192,6 +1192,10 @@ const struct function
> common_desktop_functions_possible[] = {
> { "glMultiDrawArraysIndirectCountARB", 11, -1 },
> { "glMultiDrawElementsIndirectCountARB", 11, -1 },
>
> + /* GL_AMD_framebuffer_multisample_advanced */
> + { "glRenderbufferStorageMultisampleAdvancedAMD", 45, -1 },
> + { "glNamedRenderbufferStorageMultisampleAdvancedAMD", 45, -1 },
> +
> { NULL, 0, -1 }
> };
>
> @@ -2497,6 +2501,10 @@ const struct function gles2_functions_possible[] = {
> /* GL_NV_conservative_raster_pre_snap_triangles */
> { "glConservativeRasterParameteriNV", 20, -1 },
>
> + /* GL_AMD_framebuffer_multisample_advanced */
> + { "glRenderbufferStorageMultisampleAdvancedAMD", 30, -1 },
> + { "glNamedRenderbufferStorageMultisampleAdvancedAMD", 30, -1 },
> +
> { NULL, 0, -1 }
> };
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
