On 10 August 2018 at 13:25, Martin Fuzzey <martin.fuzzey@flowbird.group> wrote: > Hi Christian, > > On 01/08/18 23:07, Christian Gmeiner wrote: >> >> Add an improved drmOpenWithType(..) clone which fixes some serious >> flaws. Some highlights: >> - using busid works only with PCI devices >> - open() w/o O_CLOEXEC >> - when build w/o udev - it creates a node: mkdir, chown(root), chmod, >> mknod >> - calls back into Xserver/DDX module >> - last but no least - borderline hacks with massive documentation [1] >> to keep this running. >> >> Signed-off-by: Christian Gmeiner <christian.gmei...@gmail.com> > > > Why do this in mesa rather than fixing (or adding a new version if necessary > for backwards compatibility) to the libdrm code? > By fixing the libdrm code, we'll break old users - something that is a no-go for open-source projects. I've been slowly chipping on libdrm3 for far too long. Sadly it's not the most enjoyable thing to hack on in one's spare time.
FWIW, Christian's second take on the topic is here [1]. HTH Emil [1] https://patchwork.freedesktop.org/series/47923/ _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
