On 13 August 2018 at 16:16, Tomasz Figa <tf...@chromium.org> wrote: > Hi Emil, > > On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> >> From: Emil Velikov <emil.veli...@collabora.com> >> >> The function name is misleading - it effectively checks if >> loader_get_driver_for_fd fails. Which can happen only only on strdup >> error - a close to impossible scenario. > > How about a DRI node which doesn't have a driver in Mesa? > Can you elaborate a bit - are you thinking of any of the following or something else: - no support for vendor X - supported vendor, missing vendor/device pci id for device X - supported vendor, built w/o it
All these are fairly different cases, with somewhat different solution for each one. Fwiw the function loader_get_driver_for_fd does: - gets the vendor/device pci id and maps that to a driver_name - if device not a pci device (or query fails) - fallback to the name as returned in drmGetVersion Thanks Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
