On Tuesday, August 28, 2018 2:02:07 PM CEST Samuel Iglesias Gonsálvez wrote: > I'll do it later today.
Done! Sam > > Thanks for contributing! > > Sam > > On 28/08/18 13:59, andrey simiklit wrote: > > Hi all, > > > > Could somebody push it if it seems good for all? > > > > Regards, > > Andrii. > > > > On Thu, Aug 23, 2018 at 4:53 PM Samuel Iglesias Gonsálvez > > > > <sigles...@igalia.com <mailto:sigles...@igalia.com>> wrote: > > The patch seems fine to me. I also tested it on Intel CI and there > > were no regressions. > > > > Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> > > <mailto:sigles...@igalia.com> > > > > Thanks, > > > > Sam > > > > On 15/08/18 17:20, asimiklit.w...@gmail.com > > > > <mailto:asimiklit.w...@gmail.com> wrote: > >> From: Andrii Simiklit <asimiklit.w...@gmail.com> > >> <mailto:asimiklit.w...@gmail.com> > >> > >> When the SVBI Payload Enable is false I guess the register R1.4 > >> which contains the Maximum Streamed Vertex Buffer Index is filled by > >> zero > >> and GS stops to write transform feedback when the transform feedback > >> is not active. > >> > >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107579 > >> Signed-off-by: Andrii Simiklit <andrii.simik...@globallogic.com> > >> <mailto:andrii.simik...@globallogic.com> > >> --- > >> > >> src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c > >> b/src/mesa/drivers/dri/i965/genX_state_upload.c index > >> ea5ad55..0f82500 100644 > >> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c > >> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c > >> @@ -2806,7 +2806,7 @@ genX(upload_gs_state)(struct brw_context *brw) > >> > >> #if GEN_GEN < 7 > >> > >> gs.SOStatisticsEnable = true; > >> if (gs_prog->info.has_transform_feedback_varyings) > >> > >> - gs.SVBIPayloadEnable = true; > >> + gs.SVBIPayloadEnable = > >> _mesa_is_xfb_active_and_unpaused(ctx); > >> > >> /* GEN6_GS_SPF_MODE and GEN6_GS_VECTOR_MASK_ENABLE are > >> enabled as it > >> > >> * was previously done for gen6.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev